perf: replace seq_cst with acquire-release memory ordering - #10
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes
std::memory_order_seq_cstoperations with explicit memory ordering.CMakeLists Motivation
Windows CI failed during linking because GoogleTest and project targets used different MSVC runtime libraries:
This caused LNK2038 and multiple definition errors.
Observation
The performance improvement compared with
seq_cstis limited.This suggests that the current bottleneck is likely not memory ordering itself, but cache-line contention between
write_idxandread_idx.The next optimization will focus on cache-line alignment and false sharing elimination.